Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Tests (DjangoCon) #1602

Merged
merged 82 commits into from
Sep 19, 2022
Merged

Faster Tests (DjangoCon) #1602

merged 82 commits into from
Sep 19, 2022

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Sep 6, 2022

This fixes #1499

  • Trying the sentry-ruby way (splitting up into multiple yaml files, this works great. I have created a script to split tox.ini into multiple yaml files automatically)
  • Trying tox-gh (does not help us, because we already have this paralleization in GitHub actions)
  • Cleaning up the yaml file in general.
  • Using a RAM drive for the tox virtualenvs in the GitHub runners
  • Removed PyPy from the test suite because it was never run. We have to reevaluate support for PyPy.

@antonpirker antonpirker changed the title Test experiments Faster Tests (DjangoCon) Sep 15, 2022
@antonpirker antonpirker marked this pull request as ready for review September 16, 2022 12:04
tox.ini Show resolved Hide resolved
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok firstly, great work!
just some random comments and one more here.

Can you document in the PR description / contributing guide what we need to do if we add/remove a certain tox configuration in tox.ini? (basically just run the script again, I guess.)

.github/workflows/test-common.yml Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@antonpirker
Copy link
Member Author

I have now made it so the CI fails when tox.ini and the existing yaml files are out of sync: https://github.com/getsentry/sentry-python/actions/runs/3082611176/jobs/4982524192

@antonpirker antonpirker merged commit f5ee56b into master Sep 19, 2022
@antonpirker antonpirker deleted the antonpirker/tests-experiments branch September 19, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run test suite in under 10 minutes
2 participants