fix(redis): import redis pipeline using full path #1565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Sentry uses
redis-py-cluster==2.1.0
which does not expose theClusterPipeline
as a top level object. The fix was introduced in version2.1.1
and another fix in2.1.2
see https://github.com/Grokzen/redis-py-cluster/blob/master/docs/release-notes.rstAnd getting following error
This PR makes sure to use the full path to import
rediscluster.pipeline.ClusterPipeline
which always available in any version now.See errors in integration tests on getsentry/relay#1413 and getsentry/relay#1414 where the sentry
master
branch is used to run those tests with newly updated python sentry-sdk dependency.Related changes which "broke" the sdk for redis-py-cluster==2.1.0 were introduced in #1543