feat(serializer): Allow classes to short circuit serializer with sentry_repr
#1322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #1300 and #1296.
We do a lot of truncation magic in our serializer to not send huge payloads.
In the process, we ignore if a user/framework sets a custom
__repr__
on a class.This PR lets users add a
sentry_repr
that will short circuit our truncation logic and pick the user defined repr.We cannot just go with checking if
__repr__
is overridden because we still want to preserve the truncation behavior for classes out there in the wild likeQueryDict
.Some notes from the TSC: