Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default argument to json.dumps in compute_tracestate_value #1318

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Provide default argument to json.dumps in compute_tracestate_value #1318

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f3555
Set default on json.dumps in compute_tracestate_value to ensure strin…
tomchuk Jan 24, 2022
3c9a94a
Merge branch 'master' into tracestate_json
sl0thentr0py Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sentry_sdk/tracing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
capture_internal_exceptions,
Dsn,
logger,
safe_str,
to_base64,
to_string,
from_base64,
Expand Down Expand Up @@ -288,7 +289,7 @@ def compute_tracestate_value(data):
tracestate entry.
"""

tracestate_json = json.dumps(data)
tracestate_json = json.dumps(data, default=safe_str)

# Base64-encoded strings always come out with a length which is a multiple
# of 4. In order to achieve this, the end is padded with one or more `=`
Expand Down