Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose custom safe_repr config #3427

Closed
sl0thentr0py opened this issue Aug 9, 2024 · 1 comment · Fixed by #3438
Closed

Expose custom safe_repr config #3427

sl0thentr0py opened this issue Aug 9, 2024 · 1 comment · Fixed by #3438
Assignees
@sl0thentr0py

Comments

@sl0thentr0py
Copy link
Member

@sl0thentr0py Thanks, yes, I think we prefer option 2 - the option for a custom repr function to be tried in safe_repr (my current understanding of how everything works is that this will both solve our needs and reduce the likelihood of this bug to creeping back in).

Thanks for giving us the choice 🙂

Originally posted by @philipstarkey in #3409 (comment)
@sl0thentr0py sl0thentr0py mentioned this issue Aug 9, 2024
Closed
@sl0thentr0py sl0thentr0py self-assigned this Aug 12, 2024
@sl0thentr0py sl0thentr0py mentioned this issue Aug 12, 2024
Merged
@sl0thentr0py
Copy link
Member Author

@philipstarkey merged, will be in next release

arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@sl0thentr0py @arjenzorgdoc
Expose custom_repr function that precedes safe_repr invocation in ser…
cb28ad2 
…ializer (getsentry#3438)

closes getsentry#3427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sl0thentr0py sl0thentr0py

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose custom_repr function that precedes safe_repr invocation in serializer getsentry/sentry-python
1 participant
@sl0thentr0py