Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask version parsing not compatible with prereleases #1095

Closed
ThiefMaster opened this issue Apr 19, 2021 · 2 comments · Fixed by #2152
Closed

Flask version parsing not compatible with prereleases #1095

ThiefMaster opened this issue Apr 19, 2021 · 2 comments · Fixed by #2152
Assignees

Comments

@ThiefMaster
Copy link

  File ".../env/lib/python3.9/site-packages/sentry_sdk/integrations/flask.py", line 71, in setup_once
    raise DidNotEnable("Unparsable Flask version: {}".format(FLASK_VERSION))
sentry_sdk.integrations.DidNotEnable: Unparsable Flask version: 2.0.0rc1

version = tuple(map(int, FLASK_VERSION.split(".")[:3]))

This assumes the version number only contains digits, so anything else that's valid in a Python version breaks the check.

@ahmedetefy ahmedetefy self-assigned this Jun 16, 2021
@ahmedetefy ahmedetefy added the bug label Jun 16, 2021
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@ThiefMaster
Copy link
Author

not a problem atm since flask isn't in rc phase but not stale since it would break again in case of a future update that includes beta/rc...

@vladanpaunovic vladanpaunovic added the Good first issue Good for newcomers label Feb 14, 2022
ohe added a commit to ohe/sentry-python that referenced this issue Mar 1, 2022
ohe added a commit to ohe/sentry-python that referenced this issue Mar 11, 2022
ohe added a commit to ohe/sentry-python that referenced this issue Mar 23, 2022
@antonpirker antonpirker self-assigned this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants