ref(tracing): Update NoOpSpan.finish signature

Make the same changes previously made to `Transaction.finish`.
getsentry · Jul 10, 2024 · 1c86489 · 1c86489
1 parent 3461068
commit 1c86489
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/sentry_sdk/tracing.py b/sentry_sdk/tracing.py
@@ -1205,8 +1205,17 @@ def get_profile_context(self):
         # type: () -> Any
         return {}
 
-    def finish(self, hub=None, end_timestamp=None):
-        # type: (Optional[Union[sentry_sdk.Hub, sentry_sdk.Scope]], Optional[Union[float, datetime]]) -> Optional[str]
+    def finish(
+        self,
+        scope=None,  # type: Optional[sentry_sdk.Scope]
+        end_timestamp=None,  # type: Optional[Union[float, datetime]]
+        *,
+        hub=None,  # type: Optional[sentry_sdk.Hub]
+    ):
+        # type: (...) -> Optional[str]
+        """
+        The `hub` parameter is deprecated. Please use the `scope` parameter, instead.
+        """
         pass
 
     def set_measurement(self, name, value, unit=""):