-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sentry Developer Metrics #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
force-pushed
the
metrics
branch
2 times, most recently
from
October 31, 2023 11:49
62bb5b7
to
46a9089
Compare
Marking as Draft again, missed some stuff
|
cleptric
force-pushed
the
metrics
branch
4 times, most recently
from
December 20, 2023 16:56
416de9a
to
7c6d596
Compare
mitsuhiko
requested changes
Dec 20, 2023
stayallive
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪨
mitsuhiko
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Sentry Developer Metrics.
See getsentry/sentry#58584
In case you're not already enrolled on our Metrics alpha program, please sign up here.
To-Dos
metrics()->timing(fn () => doSomething(), ...)
function https://develop.sentry.dev/sdk/metrics/#distributionsmetric_code_locations
option