fix: Setting the default level for crash events in Crashpad to fatal

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+**Fixes**:
+
+- Crash events are initialized with level `FATAL` ([#852](https://github.com/getsentry/sentry-native/pull/852))
+
 **Features**:
 
 - crashpad_handler: log `body` if minidump endpoint response is not `OK` ([#851](https://github.com/getsentry/sentry-native/pull/851), [crashpad#87](https://github.com/getsentry/crashpad/pull/87))

src/backends/sentry_backend_breakpad.cpp

@@ -92,6 +92,8 @@ sentry__breakpad_backend_callback(
     dump_path = sentry__path_new(descriptor.path());
 #endif
     sentry_value_t event = sentry_value_new_event();
+    sentry_value_set_by_key(
+        event, "level", sentry__value_new_level(SENTRY_LEVEL_FATAL));
 
     SENTRY_WITH_OPTIONS (options) {
         sentry__write_crash_marker(options);
@@ -116,9 +118,6 @@ sentry__breakpad_backend_callback(
         if (should_handle) {
             sentry_envelope_t *envelope = sentry__prepare_event(
                 options, event, nullptr, !options->on_crash_func);
-            // the event we just prepared is empty,
-            // so no error is recorded for it
-            sentry__record_errors_on_current_session(1);
             sentry_session_t *session = sentry__end_current_session_with_status(
                 SENTRY_SESSION_STATUS_CRASHED);
             sentry__envelope_add_session(envelope, session);

src/backends/sentry_backend_crashpad.cpp

@@ -105,9 +105,14 @@ crashpad_backend_flush_scope(
     // properties that we do not want here. But in case of a crash we use the
     // crash-event filled in the crash-handler and on_crash/before_send
     // respectively.
-    sentry_value_t event = sentry_value_is_null(data->crash_event)
-        ? sentry_value_new_object()
-        : data->crash_event;
+    sentry_value_t event = data->crash_event;
+    if (sentry_value_is_null(event)) {
+        event = sentry_value_new_object();
+        // FIXME: This should be handled in the FirstChanceHandler but that does
+        // not exist for macOS just yet.
+        sentry_value_set_by_key(
+            event, "level", sentry__value_new_level(SENTRY_LEVEL_FATAL));
+    }
 
     SENTRY_WITH_SCOPE (scope) {
         // we want the scope without any modules or breadcrumbs
@@ -149,6 +154,8 @@ sentry__crashpad_handler(int signum, siginfo_t *info, ucontext_t *user_context)
         auto *data = static_cast<crashpad_state_t *>(options->backend->data);
         sentry_value_decref(data->crash_event);
         data->crash_event = sentry_value_new_event();
+        sentry_value_set_by_key(data->crash_event, "level",
+            sentry__value_new_level(SENTRY_LEVEL_FATAL));
 
         if (options->on_crash_func) {
             sentry_ucontext_t uctx;