[MinGW + MSYS2] update documentation and setup #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
We can give it a shot at least. I’m a bit hesitant though, since I don’t want to spend too much time maintaining it myself. |
|
@Swatinem I just noted that my Remark VSCode extension auto-formated the README.md. Is this an issue ? |
It would be nice to revert that, yes. I have autoformatting for markdown in vscode, I think it comes from prettier, but not sure. |
|
Alright, I think this closes #238 ! |
Mixaill
reviewed
Apr 30, 2020
Swatinem
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and since LLVM 10 is now live in MSYS2, maybe re-enable MinGW CI builds ? It may require getsentry/crashpad#13 to pass first tho.