Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to set NDK handler strategy #1099

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Dec 6, 2024

Porting the relevant changes from sentry-java 7.x.x to ndk, so we'll have the same feature set for upcoming sentry-java 8.x.x

Copy link

github-actions bot commented Dec 6, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c28415f

@markushi markushi marked this pull request as ready for review December 6, 2024 12:42
Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (3baf0c7) to head (c28415f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   82.64%   82.58%   -0.07%     
==========================================
  Files          53       53              
  Lines        7889     7889              
  Branches     1232     1232              
==========================================
- Hits         6520     6515       -5     
- Misses       1258     1263       +5     
  Partials      111      111              

Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@markushi markushi merged commit 0380496 into master Dec 6, 2024
25 checks passed
@markushi markushi deleted the feat/ndk-handler-strategy-api branch December 6, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants