Could NOT find CURL cmake error, when using a cmake package manager, and including curl already

[bsergean]

Description

Our C++ build system uses cpm (which is based on cmake FetchContent). We bring in curl that way (with cpm), and after that we include sentry with cpm (see in the repro steps). When doing so we get a could not find curl cmake error.

This is a chicken and eggs problem, but maybe it could be solved. For some reason I didn't get it on my mac version which uses a more recent cmake.

When does the problem happen

• [x ] During build
• During run-time
• When capturing a hard crash

Environment

• OS: linux
• Compiler: gcc-11
• CMake version and config: [, SENTRY_BACKEND=breakpad]

Steps To Reproduce

set(sentry_version 5.3.0)
cpmaddpackage(
  NAME
  sentry
  VERSION
  ${sentry_version}
  OPTIONS
  "BUILD_SHARED_LIBS OFF"
  "SENTRY_TRANSPORT curl"   # Should be the default
  "SENTRY_BACKEND breakpad" # we could try crashpad, but it might have more dependencies 
  GIT_REPOSITORY
  "https://github.com/getsentry/sentry-native"
  GIT_TAG
  ${sentry_version})

then somewhere in your project, do `target_link_libraries(myproject sentry::sentry)

Log output

-- SENTRY_SDK_NAME=
CMake Error at /usr/local/cmake-3.21.4-linux-x86_64/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find CURL (missing: CURL_LIBRARY CURL_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/local/cmake-3.21.4-linux-x86_64/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/cmake-3.21.4-linux-x86_64/share/cmake-3.21/Modules/FindCURL.cmake:181 (find_package_handle_standard_args)
  build/_deps/sentry-src/CMakeLists.txt:277 (find_package)

[bsergean]

I think the fact that it builds fine on macOS is because the developer tools include a curl headers + a curl library.

/Library/Developer/CommandLineTools/SDKs/MacOSX13.1.sdk/usr/include/curl/curl.h
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/curl/curl.h

Maybe we should just install curl-dev with apt-get.

[supervacuus]

Maybe we should just install curl-dev with apt-get.

That is probably the quickest fix.

While I haven't worked with cpm yet, I would imagine that one could either set result variables like FindCURL does from the cpm-package configuration to let other packages add libcurl as if it was found via find_package. We also query the CURL_FOUND result variable not to let find_package run again if libcurl was already configured.

The other option would be to pass CMAKE_PREFIX_PATH into your sentry-native package configuration, with whatever the libcurl cpm-package provides as its build output.

[bsergean]

Those are good tips, thanks for that. Some build machines have a hard time, some others don’t, still a mystery but we’ll find a way I think.

…

On Jan 20, 2023, at 12:39 AM, Mischan Toosarani-Hausberger ***@***.***> wrote: Maybe we should just install curl-dev with apt-get. That is probably the quickest fix. While I haven't worked with cpm yet, I would imagine that one could either set result variables like FindCURL <https://cmake.org/cmake/help/latest/module/FindCURL.html> does from the cpm-package configuration to let other packages add libcurl as if it was found via find_package. We also query the CURL_FOUND result variable not to let find_package run again if libcurl was already configured. The other option would be to pass CMAKE_PREFIX_PATH <https://cmake.org/cmake/help/latest/variable/CMAKE_PREFIX_PATH.html#variable:CMAKE_PREFIX_PATH> into your sentry-native package configuration, with whatever the libcurl cpm-package provides as its build output. — Reply to this email directly, view it on GitHub <#790 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UJLW2XCAM4KB2NNJ53WTJFKXANCNFSM6AAAAAAT7OCAOI>. You are receiving this because you authored the thread.

[bsergean]

Setting CURL_FOUND to ON did the trick !

(Not sure how/whether this should be added to the doc)