fix(tracing): Set max spans to the default amount when tracing is ena…

…bled (#669)
getsentry · Jan 24, 2022 · ef36a87 · ef36a87
1 parent 2e4314b
commit ef36a87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/sentry_options.c b/src/sentry_options.c
@@ -415,6 +415,10 @@ sentry_options_set_traces_sample_rate(
         sample_rate = 1.0;
     }
     opts->traces_sample_rate = sample_rate;
+
+    if (sample_rate > 0 && opts->max_spans == 0) {
+        opts->max_spans = SENTRY_SPANS_MAX;
+    }
 }
 
 /**

diff --git a/tests/unit/test_tracing.c b/tests/unit/test_tracing.c
@@ -349,7 +349,6 @@ SENTRY_TEST(basic_spans)
 {
     sentry_options_t *options = sentry_options_new();
     sentry_options_set_traces_sample_rate(options, 1.0);
-    sentry_options_set_max_spans(options, 3);
     sentry_init(options);
 
     // Starting a child with no active transaction should fail
@@ -404,7 +403,6 @@ SENTRY_TEST(spans_on_scope)
 {
     sentry_options_t *options = sentry_options_new();
     sentry_options_set_traces_sample_rate(options, 1.0);
-    sentry_options_set_max_spans(options, 3);
     sentry_init(options);
 
     sentry_transaction_context_t *opaque_tx_cxt