add valgrind exception for false positive when memmove is an ifunc re…

…solving to memcpy
getsentry · Mar 8, 2024 · 02abaad · 02abaad
1 parent 8e41d8a
commit 02abaad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/sentry_os.c b/src/sentry_os.c
@@ -196,9 +196,7 @@ sentry__get_os_context(void)
 #elif defined(SENTRY_PLATFORM_UNIX)
 
 #    include <fcntl.h>
-#    include <string.h>
 #    include <sys/utsname.h>
-#    include <unistd.h>
 
 #    define OS_RELEASE_MAX_LINE_SIZE 128
 #    define OS_RELEASE_MAX_KEY_SIZE 64

diff --git a/tests/valgrind.txt b/tests/valgrind.txt
@@ -27,3 +27,9 @@
     ...
     fun:sentry__procmaps_read_ids_from_elf
 }
+{
+   memmove is safe to overlap even if it is an ifunc that resolves to memcpy
+   Memcheck:Overlap
+   fun:__memcpy_chk
+   fun:memmove
+}