fix(astro): prevent sentry from externalized

[anonrig]

Fixes #9777

[lforst]

This generally looks good to me. I want @Lms24 to make the last call before merging this because I lack a lot of context on the Astro SDK.

[anonrig]

This generally looks good to me. I want @Lms24 to make the last call before merging this because I lack a lot of context on the Astro SDK.

I'm happy to wait @Lms24 to land this.

[billykwok]

Just applied the changes to my repo and it doesn't seem to be working.

AFAIK, astro treats @sentry/ as external dependencies, so all dependencies are pre-bundled using esbuild without going through rollup plugins. As a result, the resolveId(id, importer) hook is not run for the import and require statements of dependencies (in this case @sentry/node). You might need to mark @sentry/ as external first.

You can verify this by printing out the id argument in the hook. Let me know if I'm missing something.

[lforst]

@billykwok I thought vite was using esbuild only as a transpiler. Otherwise any rollup/vite plugins would have a hard time working...

[Lms24]

I think the change looks good, generally. +1 on trying to limit the id modification to our @sentry/astro package.

However, I'm a bit unsure if this is enough to get the server side working with CF pages. None of our Fullstack SDKs are compatible with edge/WinterCG runtimes (except for NextJs with Vervel Edge), which I believe also comes down to our general problems with ESM support and the require statements in our http integration and Node transport. I guess we can try though!

One request: Let's guard adding the plugin similarly to how we guard adding the Sentry Vite plugin (sourcemaps) after introducing the enabled option in #10007. No need to add the plugin if Sentry is disabled.

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)	75.94 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	67.3 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)	60.93 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	31.88 KB (+0.06% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped)	30.42 KB (0%)
@sentry/browser - Webpack (gzipped)	22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)	73.34 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	65.01 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	31.16 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped)	23.16 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	203.92 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	93.81 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	68.73 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	34.12 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	67.71 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped)	22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	84.35 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped)	48.99 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped)	16.63 KB (0%)

[Lms24]

Looks good!