build(size-limit): Consistently use webpack #9910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Dec 19, 2023
size-limit report 📦
|
mydea
force-pushed
the
fn/size-limit-webpack
branch
from
17d10e6 to
3c39d8f
Compare
I noticed that in the new major it defaults to brotli compression, so need to specifically opt out of this if we want to test uncompressed sizes. Which also brings up the general point, should we use brotli instead of gzip for all compressed sizes here? 🤔 it is quite a bit smaller - e.g. ES6 full CDN bundle is 56kb vs 64kb. |
We've been using esbuild (default, from`@size-limit/preset-small-lib`) for most jobs, but webpack for the one with custom config, which is a bit inconsistent. This now updates this to always use webpack.
mydea
force-pushed
the
fn/size-limit-webpack
branch
from
3c39d8f to
b7179af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using esbuild (default, from
@size-limit/preset-small-lib) for most jobs, but webpack for the one with custom config, which is a bit inconsistent.This now updates this to always use webpack, which should be more consistent...
If we eventually get rid of the custom webpack config (e.g. when we merge this or something like it: #9826), we can revert this back to use esbuild everywhere.