ref(feedback): Refactor to better support multiple dialogs #9305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
commented
Oct 23, 2023
packages/feedback/src/widget/Icon.ts
Outdated
| const cENS = document.createElementNS.bind(document, XMLNS); | ||
| const cENS = <K extends keyof SVGElementTagNameMap>(tagName: K): SVGElementTagNameMap[K] => | ||
| // eslint-disable-next-line no-restricted-globals | ||
| document.createElementNS(XMLNS, tagName); |
There was a problem hiding this comment.
@mydea is there a good way to use document? getGlobalObj seems to be deprecated
There was a problem hiding this comment.
What about WINDOW from @sentry/browser? WINDOW.document should work I guess?
mydea
reviewed
Oct 24, 2023
mydea
reviewed
Oct 24, 2023
billyvg
force-pushed
the
feat-feedback-refactor-api-multiple-widgets
branch
from
9e01127
to
b3373b7
Compare
billyvg
force-pushed
the
feat-feedback-implement-widget-api
branch
from
1b4b74a
to
6ef6f29
Compare
billyvg
force-pushed
the
feat-feedback-refactor-api-multiple-widgets
branch
from
b3373b7
to
e0dbb83
Compare
mydea
approved these changes
Oct 25, 2023
|
Going to merge this into #9217 so i'm not juggling multiple git stacks |
billyvg
force-pushed
the
feat-feedback-implement-widget-api
branch
from
6ef6f29
to
21454dc
Compare
billyvg
force-pushed
the
feat-feedback-refactor-api-multiple-widgets
branch
from
e0037f1
to
267ba37
Compare
billyvg
added a commit
that referenced
this pull request
Oct 26, 2023
- refactor to support multiple widgets - add `attachTo` and `createWidget` public methods to create respective components.
billyvg
added a commit
that referenced
this pull request
Oct 31, 2023
- refactor to support multiple widgets - add `attachTo` and `createWidget` public methods to create respective components.
billyvg
added a commit
that referenced
this pull request
Oct 31, 2023
- refactor to support multiple widgets - add `attachTo` and `createWidget` public methods to create respective components.
billyvg
added a commit
that referenced
this pull request
Nov 1, 2023
- refactor to support multiple widgets - add `attachTo` and `createWidget` public methods to create respective components.
billyvg
added a commit
that referenced
this pull request
Nov 1, 2023
- refactor to support multiple widgets - add `attachTo` and `createWidget` public methods to create respective components.
billyvg
added a commit
that referenced
this pull request
Nov 6, 2023
- refactor to support multiple widgets - add `attachTo` and `createWidget` public methods to create respective components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attachToandcreateWidgetpublic methods to create respective components.Requires #9217