Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Add missing Profiling types (macho debug image, profile measurements, stack frame properties) #9277

Merged
merged 12 commits into from
Oct 19, 2023

Conversation

krystofwoldrich
Copy link
Member

Adds measurements to Profile type, this will be used in RN and is already present in the native SDKs.

Add macho debug image, this will also be used in RN, where we load the images from the native SDK.

@krystofwoldrich krystofwoldrich changed the title feat(types): Add macho debug image and measurements to Profile type feat(types): Add missing Profiling types (macho debug image, profile measurements, stack frame properties) Oct 18, 2023
@krystofwoldrich krystofwoldrich requested review from JonasBa and lforst and removed request for JonasBa October 18, 2023 11:38
@krystofwoldrich krystofwoldrich marked this pull request as ready for review October 18, 2023 11:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 82.51 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 71.66 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.63 KB (0%)
@sentry/browser - Webpack (gzipped) 21.24 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 73.01 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.68 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.07 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 233.76 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 87.08 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.71 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.44 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 82.97 KB (0%)
@sentry/react - Webpack (gzipped) 21.27 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 99.38 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 47.54 KB (0%)

@krystofwoldrich
Copy link
Member Author

Deno test fails on DebugImage mismatch because the Deno test downloads the package from npm.

@krystofwoldrich
Copy link
Member Author

@lforst @AbhiPrasad I don't know how to change Dino to resolve the deps locally, is it okay to allow the Dino job to fail?

@lforst
Copy link
Member

lforst commented Oct 18, 2023

@krystofwoldrich Opened #9297 to unblock

@krystofwoldrich krystofwoldrich merged commit d7df098 into develop Oct 19, 2023
85 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-update-profile-types-with-native branch October 19, 2023 13:25
@AbhiPrasad
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants