-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): Add missing Profiling types (macho debug image, profile measurements, stack frame properties) #9277
Merged
krystofwoldrich
merged 12 commits into
develop
from
kw-update-profile-types-with-native
Oct 19, 2023
Merged
feat(types): Add missing Profiling types (macho debug image, profile measurements, stack frame properties) #9277
krystofwoldrich
merged 12 commits into
develop
from
kw-update-profile-types-with-native
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
changed the title
feat(types): Add macho debug image and measurements to Profile type
feat(types): Add missing Profiling types (macho debug image, profile measurements, stack frame properties)
Oct 18, 2023
krystofwoldrich
requested review from
JonasBa and
lforst
and removed request for
JonasBa
October 18, 2023 11:38
size-limit report 📦
|
6 tasks
…ive' into kw-update-profile-types-with-native
Deno test fails on DebugImage mismatch because the Deno test downloads the package from npm. |
lforst
approved these changes
Oct 18, 2023
AbhiPrasad
approved these changes
Oct 18, 2023
@lforst @AbhiPrasad I don't know how to change Dino to resolve the deps locally, is it okay to allow the Dino job to fail? |
@krystofwoldrich Opened #9297 to unblock |
@krystofwoldrich - this was released with https://github.com/getsentry/sentry-javascript/releases/tag/7.75.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds measurements to Profile type, this will be used in RN and is already present in the native SDKs.
Add macho debug image, this will also be used in RN, where we load the images from the native SDK.