fix(utils): Avoid pre_context
and context_line
overlap if frame lineno is out of bounds
#8722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding context lines to a stack frame we need to handle the edge case that the frame's
lineno
is greater than the length of source code lines we obtained (this can happen for various reasons). We do this by assigning the last line of the source code lines array to thecontext_line
and assigning the preceding lines aspre_context
.However, I noticed while finishing up #8699 that, that in
addContextToFrame
we were off by one for thepre_context
line determination, causing overlap betweenpre_context
andcontext_line
. I'm pretty sure we want to avoid this, so this PR removes the overlap by fixing the off-by one error.Adjusted the overlap test to show the change in behaviour and added a new one to ensure we correctly truncate too long lines.
Note, this concerns both, Node and Browser
ContextLines
integrations.