Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (hopefully) the size-limit CI check.
After a lot of digging, I figured out that when the size-limit action runs on CI, it basically doesn't do the same as on the PR. On master, we do not skip the install & build step, but re-run them. Especially, we also just run
yarn install
&yarn build
, which may have a slightly different outcome. Additionally, this also means that the size check on master takes > 8min, because we re-run all the build stuff etc.I made a PR to fix our size-limit action: getsentry/size-limit-action#7
For now, we can simply use this branch, until this has been merged.
Note that while debugging this, I also noticed a necessary improvement with the label check. basically, it appeares that the labels that we can fetch from the github context are always the ones that existed when the action run was initially made. So if you added a label later and re-run a workflow, it will not be updated. Instead, we need to fetch the labels from the github API, which the provided action does.
With these changes, hopefully the size limit output will be stable between master & PR branches again.
Note: Using custom branch of pr-labels-action until joerick/pr-labels-action#10 is merged & released