Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix size-limit check #6875

Merged
merged 2 commits into from
Jan 19, 2023
Merged

ci: Fix size-limit check #6875

merged 2 commits into from
Jan 19, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 19, 2023

This PR fixes (hopefully) the size-limit CI check.

After a lot of digging, I figured out that when the size-limit action runs on CI, it basically doesn't do the same as on the PR. On master, we do not skip the install & build step, but re-run them. Especially, we also just run yarn install & yarn build, which may have a slightly different outcome. Additionally, this also means that the size check on master takes > 8min, because we re-run all the build stuff etc.

I made a PR to fix our size-limit action: getsentry/size-limit-action#7
For now, we can simply use this branch, until this has been merged.

Note that while debugging this, I also noticed a necessary improvement with the label check. basically, it appeares that the labels that we can fetch from the github context are always the ones that existed when the action run was initially made. So if you added a label later and re-run a workflow, it will not be updated. Instead, we need to fetch the labels from the github API, which the provided action does.

With these changes, hopefully the size limit output will be stable between master & PR branches again.

Note: Using custom branch of pr-labels-action until joerick/pr-labels-action#10 is merged & released

@mydea mydea added the Dev: CI label Jan 19, 2023
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad January 19, 2023 15:05
@mydea mydea self-assigned this Jan 19, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.82 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.21 KB (0%)
@sentry/browser - Webpack (minified) 66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.74 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.27 KB (-0.82% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.05 KB (-1.01% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.54 KB (-0.59% 🔽)

@mydea mydea merged commit ae56638 into master Jan 19, 2023
@mydea mydea deleted the fn/size-check-fix branch January 19, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants