ref(angular): Add more tests to the error handler #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
changed the title
theofidry
changed the title
onurtemizkan
approved these changes
Dec 7, 2022
hunhejj
approved these changes
Dec 9, 2022
| expect(captureExceptionSpy).toHaveBeenCalledWith('Handled unknown error', expect.any(Function)); | ||
| }); | ||
|
|
||
| it('handleError method extracts ErrorEvent which has an error has an error', () => { |
There was a problem hiding this comment.
Suggested change
| it('handleError method extracts ErrorEvent which has an error has an error', () => { | |
| it('handleError method extracts ErrorEvent which has an error as an error', () => { |
Co-authored-by: hunhejj <[email protected]>
Lms24
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Hi @theofidry, thanks for adding these tests! Seems like a bunch of cases we have now covered. Appreciate the help!
|
Thanks for adding these tests @theofidry. Will take a look at your next PR soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more tests to cover the problematic paths mentioned in #6332.