-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): Update to Web Vitals v3 #5987
Conversation
Let's make sure we update https://github.com/getsentry/sentry-javascript/blob/master/packages/tracing/src/browser/web-vitals/README.md as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder that we’ll need to update the readme in the web-vitals folder!
Was just on my way to do that and noticed they've already released 3.0.4 with a bug fix so I'll try and get that in first! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim!
Closes #5462
This merges in changes from Web Vitals v3.0.4 while maintaining the original changes and simplifications to the vendored code.
I have not carried across the file renames (ie.
getXXX
>onXXX
) yet because they're not displayed as renames in the diffs.Below is the web vitals changelog with the items I consider not relevant to this vendored code crossed out. The major change which probably needs considering in tracing is that it now detects prerendered pages. That PR suggests that these page loads should be considered differently to regular page loads since the metrics are likely to vary.
v3.0.3 (2022-10-04)
Ensureattribution
object is always present in attribution build (#265)v3.0.2 (2022-09-14)
Set an explicit unpkg dist file (#261)v3.0.1 (2022-08-31)
Use the cjs extension for all UMD builds (#257)v3.0.0 (2022-08-24)
[BREAKING] Add a config object param to all metric functions (#225)[BREAKING] Report TTFB after a bfcache restore (#220)Update the metric ID prefix for v3 (#251)Move the Navigation Timing API polyfill to the base+polyfill build (#248)Add a metric rating property (#246)Add deprecation notices for base+polyfill builds (#242)Add a new attribution build for debugging issues in the field (#237, #244)Rename the(Add a config object param to all metric functions GoogleChrome/web-vitals#225), #227)ReportHandler
type toReportCallback
, with alias for back-compat ([Fix Tracekit for firefox/xulrunner chrome code #225]Add support for the new INP metric (#221, #232)RenamegetXXX()
functions toonXXX()
(#222)navigationType
property to the Metric object (#219)v2.1.4 (2022-01-20)
Prevent TTFB from reporting after bfcache restore (#201)v2.1.3 (2022-01-06)
v2.1.2 (2021-10-11)
Ensure reported TTFB values are less than the current page time (#187)v2.1.1 (2021-10-06)
Add feature detects to support Opera mini in extreme data saver mode (#186)