test(e2e): Add behaviour test for Transactions in standard React E2E tests application #5912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
changed the title
This was referenced Oct 10, 2022
AbhiPrasad
approved these changes
Oct 10, 2022
Base automatically changed from
lforst-standard-react-application-behaviour-e2e-test
to
master
October 11, 2022 08:18
…ct-application-transaction-session-tests
lforst
force-pushed
the
lforst-standard-react-application-transaction-session-tests
branch
from
2a5733b to
ffcb4b9
Compare
AbhiPrasad
approved these changes
Oct 11, 2022
| return undefined; | ||
| } | ||
| }); | ||
| const recordedTransactionEventIds = (await recordedTransactionsHandle.jsonValue()) as string[]; |
There was a problem hiding this comment.
l: Why is the type assertion needed? Shouldn’t we handled the other case here?
| const recordedTransactionEventIds = (await recordedTransactionsHandle.jsonValue()) as string[]; | ||
|
|
||
| const timeout = setTimeout(() => { | ||
| throw new Error('Timeout reached while polling events.'); |
There was a problem hiding this comment.
l: let’s make this a util that (timeout + fetch):
- handles a timeout for polling
- allows for a hardcoded retry amount
- throws an error when 500s are returned
We can also do this in a follow up PR, since we are consolidating with the errors tests.
AbhiPrasad
approved these changes
Oct 11, 2022
lforst
deleted the
lforst-standard-react-application-transaction-session-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5855
Similar to #5909 adds an behaviour E2E test that checks whether pageload and navigation transactions correctly end up in Sentry for a React application.