Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(serverless): set ignoreSentryErrors to true by default #4994

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

vladanpaunovic
Copy link
Contributor

This PR is adding on top of the #4620 making ignoreSentryErrors: true by default.

When rate limiting is enabled, users get 429s. Whenever they experience this, they fix/fallback into adding:

const Sentry = require('@sentry/serverless');

async function main() {
  return { statusCode: 200, body: 'pong' };
}

exports.handler = Sentry.AWSLambda.wrapHandler(main, {
  ignoreSentryErrors: true,
});

so they can get ignoreSentryErrors: true.

Using our lambda layer and having ignoreSentryErrors: true by default will make their setup a working out-of-the-box solution:

exports.handler = function(event, context, callback) {
  return { statusCode: 200, body: 'pong' };
}

Fixes: #4949 #4582 #4799

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.35 KB (-8.87% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 57.52 KB (-10.98% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.13 KB (-9.19% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 51.75 KB (-10.73% 🔽)
@sentry/browser - Webpack (gzipped + minified) 20.94 KB (-9.88% 🔽)
@sentry/browser - Webpack (minified) 72.5 KB (-11.28% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.98 KB (-9.89% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.97 KB (-4.34% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.13 KB (-7.45% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.64 KB (-7.52% 🔽)

@kamilogorek
Copy link
Contributor

Makes sense to me

@vladanpaunovic vladanpaunovic merged commit 4176bcb into 7.x Apr 27, 2022
@vladanpaunovic vladanpaunovic deleted the vladan-ignore-sentry-errors branch April 27, 2022 08:41
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants