Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): Adjust sideEffects package.json entry for v7 #4987

Merged
merged 1 commit into from
Apr 26, 2022
Merged

fix(tracing): Adjust sideEffects package.json entry for v7 #4987

merged 1 commit into from
Apr 26, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 26, 2022 •
edited
Loading

This PR adjusts the fix from #4955 which was merged into 6.19.7 for v7. It changes the sideEffects paths in package.json of @sentry/tracing by renaming the dist dir to cjs.

@Lms24
fix(tracing): adjust sideEffects package.json entry
376a3f1 
rename `dist` to `cjs` in the Tracing sideEffects paths
adjusts fix from 6.19.7 for v7
@Lms24 Lms24 requested a review from AbhiPrasad April 26, 2022 15:58
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.86 KB (-1.41% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.09 KB (-2.36% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.54 KB (-1.73% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.81 KB (-2% 🔽)
@sentry/browser - Webpack (gzipped + minified) 21.77 KB (-6.3% 🔽)
@sentry/browser - Webpack (minified) 74.12 KB (-9.3% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.81 KB (-6.31% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 46.21 KB (-3.83% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.67 KB (-1.55% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.09 KB (-1.61% 🔽)

@Lms24 Lms24 merged commit 8a1ad9e into 7.x Apr 26, 2022
@Lms24 Lms24 deleted the lms-fix-tracing-side-effects branch April 26, 2022 16:21
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@Lms24 @lobsterkatie
fix(tracing): Adjust sideEffects package.json entry for v7 (#4987)
022e65d 
adjust the fix from #4955 which was merged into 6.19.7 for v7. Change the sideEffects paths in package.json of @sentry/tracing by renaming the `dist` dir to `cjs`.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@Lms24 @lobsterkatie
fix(tracing): Adjust sideEffects package.json entry for v7 (#4987)
e6a51cb 
adjust the fix from #4955 which was merged into 6.19.7 for v7. Change the sideEffects paths in package.json of @sentry/tracing by renaming the `dist` dir to `cjs`.
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@Lms24 @AbhiPrasad
fix(tracing): Adjust sideEffects package.json entry for v7 (#4987)
c6f8f22 
adjust the fix from #4955 which was merged into 6.19.7 for v7. Change the sideEffects paths in package.json of @sentry/tracing by renaming the `dist` dir to `cjs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @AbhiPrasad