Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] feat: Delete deprecated startSpan and child methods #4849

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[v7] feat: Delete deprecated startSpan and child methods #4849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de9354
feat(hub): Remove startSpan method
AbhiPrasad Apr 4, 2022
d4e81b7
feat(tracing): Remove start method
AbhiPrasad Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/hub/src/hub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ import {
Primitive,
SessionContext,
Severity,
Span,
SpanContext,
Transaction,
TransactionContext,
User,
Expand Down Expand Up @@ -384,13 +382,6 @@ export class Hub implements HubInterface {
}
}

/**
* @inheritDoc
*/
public startSpan(context: SpanContext): Span {
return this._callExtensionMethod('startSpan', context);
}

/**
* @inheritDoc
*/
Expand Down
10 changes: 0 additions & 10 deletions packages/tracing/src/span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,16 +149,6 @@ export class Span implements SpanInterface {
}
}

/**
* @inheritDoc
* @deprecated
*/
public child(
spanContext?: Pick<SpanContext, Exclude<keyof SpanContext, 'spanId' | 'sampled' | 'traceId' | 'parentSpanId'>>,
): Span {
return this.startChild(spanContext);
}

/**
* @inheritDoc
*/
Expand Down
6 changes: 0 additions & 6 deletions packages/types/src/hub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { Primitive } from './misc';
import { Scope } from './scope';
import { Session, SessionContext } from './session';
import { Severity } from './severity';
import { Span, SpanContext } from './span';
import { CustomSamplingContext, Transaction, TransactionContext } from './transaction';
import { User } from './user';

Expand Down Expand Up @@ -180,11 +179,6 @@ export interface Hub {
/** Returns all trace headers that are currently on the top scope. */
traceHeaders(): { [key: string]: string };

/**
* @deprecated No longer does anything. Use use {@link Transaction.startChild} instead.
*/
startSpan(context: SpanContext): Span;

/**
* Starts a new `Transaction` and returns it. This is the entry point to manual tracing instrumentation.
*
Expand Down
8 changes: 0 additions & 8 deletions packages/types/src/span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,6 @@ export interface Span extends SpanContext {
*/
setHttpStatus(httpStatus: number): this;

/**
* Use {@link startChild}
* @deprecated
*/
child(
spanContext?: Pick<SpanContext, Exclude<keyof SpanContext, 'spanId' | 'sampled' | 'traceId' | 'parentSpanId'>>,
): Span;

/**
* Creates a new `Span` while setting the current `Span.id` as `parentSpanId`.
* Also the `sampled` decision will be inherited.
Expand Down