Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed last comma on object return, solves crash on IE9 #385

Merged
merged 1 commit into from
Oct 1, 2015
Merged

Removed last comma on object return, solves crash on IE9 #385

merged 1 commit into from
Oct 1, 2015

Conversation

urodoz
Copy link
Contributor

@urodoz urodoz commented Oct 1, 2015

No description provided.

benvinegar added a commit that referenced this pull request Oct 1, 2015
Removed last comma on object return, solves crash on IE9
@benvinegar benvinegar merged commit 38cb3e9 into getsentry:master Oct 1, 2015
@benvinegar
Copy link
Contributor

Thanks!

@mattrobenolt
Copy link
Contributor

@benvinegar shouldn't uglify remove this when compiled?

@mattrobenolt
Copy link
Contributor

And/or can we get our linter to handle this?

@benvinegar
Copy link
Contributor

Re Uglify – not sure. But I think it should work with/without minification, IMHO.

And/or can we get our linter to handle this?

It appears the laxcomma JSHint rule was deprecated:

http://jshint.com/docs/options/#laxcomma

I'm in favor of switching to ESLint, as we've done with the main Sentry project.

@mattrobenolt
Copy link
Contributor

But I think it should work with/without minification, IMHO.

Agreed, was just curious if this issue existed in the minified version, since that is the primary consumer.

I'm in favor of switching to ESLint, as we've done with the main Sentry project.

#386 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants