fix(web-vitals): Check for valid entry in updatedCLS #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
Jul 19, 2021
dashed
reviewed
Jul 19, 2021
| @@ -43,7 +43,8 @@ export const getUpdatedCLS = (onReport: ReportHandler, reportAllChanges?: boolea | |||
|
|
|||
| const entryHandler = (entry: LayoutShift): void => { | |||
| // Only count layout shifts without recent user input. | |||
| if (!entry.hadRecentInput) { | |||
| // TODO: Figure out why entry can be undefined | |||
| if (entry && !entry.hadRecentInput) { | |||
There was a problem hiding this comment.
@AbhiPrasad you'll also want to check if sessionEntries is a non-empty array on line 54. lastSessionEntry could be undefined as well
size-limit report
|
kamilogorek
approved these changes
Jul 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per comment in #2925 (comment)
Still not sure why this happens, but would like to continue to test on Sentry.