Don't require a user in the DSN #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'd prefer proxies just take the input and deal with passing it forward. Can you see that as being unreasonsable? |
|
Talked about this over IRC. This is similar to how we used Sentry at Disqus. Basically pass thru everything to a backend, and apply a new DSN on the backend. I'm fine w/ supporting that use case for now, at least until we have a better answer to this behavior. |
dcramer
added a commit
that referenced
this pull request
Aug 7, 2015
Don't require a user in the DSN
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raven-jsrequires a user part in the DSN passed toRaven.config, but in some scenarios this isn't desired. This PR makesuserand optional part.In our configuration, our sentry instance isn't publicly available, and we proxy requests from our frontend application through our backend app for reporting; because of this, we use our already authenticated users (and sentry auth is handled via the backend). We were on a very old version of
raven-jswhich did not have this restriction. This restriction blocks us from being able to upgrade.Let me know if you have any questions/requests, and thanks for your time!