ref: Remove circular dependency in @sentry/node #3335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rolluping code that uses sentry, I got a warning for circular references in
@sentry/node
. Here’s a summary of what references what:This could be resolved by extracting either
flush
orlogAndExitProcess
to a lower-level module. I opted to movelogAndExitProcess
because it is not public and because it seems neat that a function that is only called fromintegrations
is placed inside that directory, not above it.