Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-vitals): Capture extra information from LCP and CLS web vitals. #3012

Closed
wants to merge 1 commit into from

Conversation

dashed
Copy link
Member

@dashed dashed commented Oct 27, 2020

Be able to capture extra information from LCP and CLS web vitals.

For LCP, we'd like to know the element (or image) that contributed the largest contentful paint:

For CLS, we'd like to know the top 5 DOM nodes contributing the the CLS scores:

These will be surfaced in the product to indicate source of poor LCP or CLS scores.

Screen Shot 2020-10-27 at 4 14 07 PM

Screen Shot 2020-10-27 at 5 17 11 PM

TODO

  • add DOM element source for FID

@dashed dashed requested review from a team October 27, 2020 20:28
@dashed dashed requested a review from kamilogorek as a code owner October 27, 2020 20:28
@dashed dashed self-assigned this Oct 27, 2020
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.62 KB (-0.01% 🔽)
@sentry/browser - Webpack 20.46 KB (0%)
@sentry/react - Webpack 20.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.72 KB (+0.41% 🔺)

@dashed
Copy link
Member Author

dashed commented Oct 28, 2020

I'm going to hold off merging this as there might be changes I'd like to put in.

@wmak wmak removed the request for review from a team March 2, 2021 18:47
@dashed
Copy link
Member Author

dashed commented Apr 20, 2021

Closing this in favour of #3427 . I will add the CLS portion in a separate PR if there is a product need for it.

@dashed dashed closed this Apr 20, 2021
@kamilogorek kamilogorek deleted the lcp-cls-attribution branch September 15, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants