Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tracing of google cloud requests #2981

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

marshall-lee
Copy link
Contributor

This PR implements tracing of requests to google cloud services.
It implements interception for both HTTP REST and GRPC clients.

private readonly _optional: boolean;

public constructor(options: { optional?: boolean } = {}) {
this._optional = options.optional || false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be falsy anyway, but we can leave it as is to be more explicit.

@@ -0,0 +1,139 @@
jest.mock('dns');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'll definitely reuse this setup for some of my other tests

@kamilogorek kamilogorek merged commit 9b6f448 into getsentry:master Oct 20, 2020
@marshall-lee marshall-lee deleted the serverless/gcpservices branch October 20, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants