Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referer to UserAgent integration #2906

Closed
wants to merge 1 commit into from
Closed

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Sep 15, 2020

No description provided.

@dcramer
Copy link
Member Author

dcramer commented Sep 15, 2020

Yall should probably rename this given it already was more than UserAgent. Just make it HTTP context since thats what it is.

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.71 KB (+0.09% 🔺)
@sentry/browser - Webpack 18.53 KB (+0.09% 🔺)
@sentry/react - Webpack 18.53 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 23.49 KB (+0.1% 🔺)

@dcramer
Copy link
Member Author

dcramer commented Sep 16, 2020

Can yall take over the refactor? I just want this in and its a tiny change that is needed for missing information.

@lobsterkatie
Copy link
Member

Can yall take over the refactor? I just want this in and its a tiny change that is needed for missing information.

Yup. Done.

@lobsterkatie lobsterkatie deleted the dcramer-patch-1 branch September 16, 2020 16:52
Lms24 added a commit that referenced this pull request May 4, 2022
As suggested in this [comment](#2906 (comment)) of #2906, rename the Browser `UserAgent` integration to `HttpContext`. The integration does more than collecting the user agent information and thus the old name wasn't reflecting its entire purpose.
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
As suggested in this [comment](#2906 (comment)) of #2906, rename the Browser `UserAgent` integration to `HttpContext`. The integration does more than collecting the user agent information and thus the old name wasn't reflecting its entire purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants