Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Expose sentry request for electron #2774

Merged
merged 1 commit into from
Jul 24, 2020
Merged

ref: Expose sentry request for electron #2774

merged 1 commit into from
Jul 24, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jul 24, 2020

No description provided.

@HazAT HazAT requested a review from kamilogorek as a code owner July 24, 2020 14:01
@HazAT HazAT self-assigned this Jul 24, 2020
AbhiPrasad
AbhiPrasad approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need changelog, but if we are cutting release we can do that then.

@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.249 kB) (ES6: 16.3652 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 067928d

@HazAT HazAT merged commit e771b41 into master Jul 24, 2020
@HazAT HazAT deleted the ref/expose-sentry-request branch July 24, 2020 14:10
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.65 KB (+0.01% 🔺)
@sentry/browser - Webpack 18.42 KB (0%)
@sentry/react - Webpack 18.42 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.57 KB (+0.24% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennmueng jennmueng jennmueng approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HazAT @getsentry-bot @AbhiPrasad @jennmueng