fix: Remove unknown_error transaction status #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashed
reviewed
Feb 19, 2020
| @@ -91,7 +91,7 @@ export enum SpanStatus { | |||
| /** The operation completed successfully. */ | |||
| Ok = 'ok', | |||
| /** Deadline expired before operation could complete. */ | |||
| DealineExceeded = 'deadline_exceeded', | |||
kamilogorek
reviewed
Feb 19, 2020
| event.type === 'transaction' && | ||
| event.timestamp && | ||
| event.start_timestamp && | ||
| (event.timestamp - event.start_timestamp > Tracing.options.maxTransactionDuration || |
There was a problem hiding this comment.
I'd extract this to something more descriptive like isOutdatedTransaction or something, as its easier to understand what these 2 timing checks do
HazAT
changed the title
kamilogorek
approved these changes
Feb 19, 2020
|
looks like this hasn't fully resolved the situation, as all recent transactions in some samples i pulled are unknonw_error |
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ title