feat!: Remove autoSessionTracking option
#14802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
Jan 7, 2025
| @@ -6,6 +6,5 @@ window.Sentry = Sentry; | |||
| Sentry.init({ | |||
| dsn: 'https://[email protected]/1337', | |||
| integrations: [captureConsoleIntegration()], | |||
| autoSessionTracking: false, | |||
There was a problem hiding this comment.
iirc, we opted out of session tracking for some tests due to session envelopes colliding with the envelope we're waiting for. Do we need to filter on browserSessionIntegration instead here? Might as well be old code and this is no longer a concern. I guess we'd find out with the flaky test detector 🤔
There was a problem hiding this comment.
Good point actually. I didn't consider that. I agree though that we would probably catch anything weird in the flakey test detector. Maybe the autoSessionTrackings here are also from copy and pasting tests.
I will merge this as is cause I'd err on removing unneeded logic. If there are any CI failures coming up we may attribute it to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14609