ci(v9): Ensure CI runs on v8 & v9 branches #14604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Dec 6, 2024
size-limit report 📦
|
lforst
reviewed
Dec 6, 2024
| - master | ||
| - v9 | ||
| - v8 | ||
| - release/** |
There was a problem hiding this comment.
previously we didn't have a double ** here, mistake?
There was a problem hiding this comment.
hmm I just aligned this with the build flow, IMHO this is fine (worst case this covers more branches for this check which would be fine I guess)?
lforst
approved these changes
Dec 6, 2024
mydea
added a commit
that referenced
this pull request
Dec 11, 2024
In order for us to have size-limit comparison etc, we need to ensure CI runs on v8 & v9 branches too.
mydea
added a commit
that referenced
this pull request
Dec 13, 2024
In order for us to have size-limit comparison etc, we need to ensure CI runs on v8 & v9 branches too.
mydea
added a commit
that referenced
this pull request
Dec 13, 2024
In order for us to have size-limit comparison etc, we need to ensure CI runs on v8 & v9 branches too.
lforst
pushed a commit
that referenced
this pull request
Dec 13, 2024
In order for us to have size-limit comparison etc, we need to ensure CI runs on v8 & v9 branches too.
mydea
added a commit
that referenced
this pull request
Dec 16, 2024
In order for us to have size-limit comparison etc, we need to ensure CI runs on v8 & v9 branches too.
mydea
added a commit
that referenced
this pull request
Dec 16, 2024
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for us to have size-limit comparison etc, we need to ensure CI runs on v8 & v9 branches too.