-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 8.41.0 #14502
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
7a10218
feat(core): Deprecate `urlEncode` (#14406)
lforst fc79e97
feat(core): Deprecate `arrayify` (#14405)
lforst 1b0382e
feat(core): Deprecate `validSeverityLevels` (#14407)
lforst 99817ea
Merge pull request #14428 from getsentry/master
github-actions[bot] 9c6028e
ci: Fix canary test workflow (#14429)
mydea 498d6d1
feat(utils): Deprecate `@sentry/utils` (#14431)
lforst d49f1cb
feat(utils/core): Deprecate `addRequestDataToEvent` and `extractReque…
lforst ce1df3e
test(nextjs): Adapt slow test (#14403)
chargome b0c3f5f
feat(core): Log warnings when returning `null` in `beforeSendSpan` (#…
chargome 6fbab43
feat(nuxt): Only delete public source maps (#14438)
s1gr1d 05479b8
feat(nuxt): Add filter for not found source maps (devtools) (#14437)
s1gr1d d8d9324
test: Add tests to demonstrate root trace ID behavior (#14426)
mydea 807883e
feat(vue): Deprecate configuring Vue tracing options anywhere else ot…
lforst 8f6dd04
fix(nextjs): Don't report `NEXT_REDIRECT` from browser (#14440)
NEKOYASAN 56e73ce
chore: Add external contributor to CHANGELOG.md (#14452)
HazAT 8d1dbb1
feat(utils): Deprecate `memoBuilder`, `BAGGAGE_HEADER_NAME`, and `mak…
lforst 1fd377f
test(nextjs): Add test for redirects from server actions (#14451)
chargome 1b7815a
test(nextjs): Fix turbopack test (#14455)
chargome 3742bd3
feat(core): Deprecate `flatten` (#14454)
andreiborza d9909e0
chore(docs): Add `flatten` deprecation to v9 migration guide (#14460)
andreiborza 1a31ec4
ref(browser): Avoid optional chaining (#14457)
mydea b271bc8
feat(core): Update & deprecate `undefined` option handling (#14450)
mydea fc1d986
ref: Remove & streamline some debug logs (#14456)
mydea 91a4985
feat(core/utils): Deprecate `getNumberOfUrlSegments` (#14458)
lforst cf368b1
meta: Backfill v9 migration guide items (#14459)
lforst b59ce07
feat: Streamline `sentry-trace`, `baggage` and DSC handling (#14364)
mydea 1d32374
chore(nuxt): Remove nft override to ensure we are testing with latest…
andreiborza 973ef9c
chore: Add GHSA entry for nuxt e2e test (#14490)
chargome 23e3783
meta(nuxt): Require minimum Nuxt v3.7.0 (#14473)
s1gr1d 09a31d1
feat(node): Add `openTelemetryInstrumentations` option (#14484)
lforst de65590
feat(core): Further optimize debug ID parsing (#14365)
timfish 1e0cb04
ref(core): Do not check baggage validity (#14479)
mydea 3e7969f
feat: Deprecate `registerEsmLoaderHooks.include` and `registerEsmLoad…
lforst a4138e9
perf(opentelemetry): Bucket spans for cleanup (#14154)
fmorett f7289c4
meta(changelog): Update changelog for 8.41.0
lforst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
fail-on-severity: 'high' | ||
allow-ghsas: | ||
# dependency review does not allow specific file exclusions | ||
# we use an older version of NextJS in our tests and thus need to | ||
# we use an older version of NextJS in our tests and thus need to | ||
# exclude this | ||
# once our minimum supported version is over 14.1.1 this can be removed | ||
- GHSA-fr5h-rqp8-mj6g | ||
# we need this for an E2E test for the minimum required version of Nuxt 3.7.0 | ||
- GHSA-v784-fjjh-f8r4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
...ser-integration-tests/suites/public-api/startSpan/parallel-root-spans-in-scope/subject.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Sentry.withScope(() => { | ||
Sentry.startSpan({ name: 'test_span_1' }, () => undefined); | ||
Sentry.startSpan({ name: 'test_span_2' }, () => undefined); | ||
}); |
41 changes: 41 additions & 0 deletions
41
...rowser-integration-tests/suites/public-api/startSpan/parallel-root-spans-in-scope/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import { expect } from '@playwright/test'; | ||
|
||
import type { TransactionEvent } from '@sentry/types'; | ||
import { sentryTest } from '../../../../utils/fixtures'; | ||
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../utils/helpers'; | ||
|
||
sentryTest( | ||
'should send manually started parallel root spans outside of root context', | ||
async ({ getLocalTestUrl, page }) => { | ||
if (shouldSkipTracingTest()) { | ||
sentryTest.skip(); | ||
} | ||
|
||
const url = await getLocalTestUrl({ testDir: __dirname }); | ||
|
||
const transaction1ReqPromise = waitForTransactionRequest(page, event => event.transaction === 'test_span_1'); | ||
const transaction2ReqPromise = waitForTransactionRequest(page, event => event.transaction === 'test_span_2'); | ||
|
||
await page.goto(url); | ||
|
||
const [transaction1Req, transaction2Req] = await Promise.all([transaction1ReqPromise, transaction2ReqPromise]); | ||
|
||
const transaction1 = envelopeRequestParser<TransactionEvent>(transaction1Req); | ||
const transaction2 = envelopeRequestParser<TransactionEvent>(transaction2Req); | ||
|
||
expect(transaction1).toBeDefined(); | ||
expect(transaction2).toBeDefined(); | ||
|
||
const trace1Id = transaction1.contexts?.trace?.trace_id; | ||
const trace2Id = transaction2.contexts?.trace?.trace_id; | ||
|
||
expect(trace1Id).toBeDefined(); | ||
expect(trace2Id).toBeDefined(); | ||
|
||
// We use the same traceID from the root propagation context here | ||
expect(trace1Id).toBe(trace2Id); | ||
|
||
expect(transaction1.contexts?.trace?.parent_span_id).toBeUndefined(); | ||
expect(transaction2.contexts?.trace?.parent_span_id).toBeUndefined(); | ||
}, | ||
); |
8 changes: 8 additions & 0 deletions
8
...ration-tests/suites/public-api/startSpan/parallel-root-spans-with-parentSpanId/subject.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Sentry.getCurrentScope().setPropagationContext({ | ||
parentSpanId: '1234567890123456', | ||
spanId: '123456789012345x', | ||
traceId: '12345678901234567890123456789012', | ||
}); | ||
|
||
Sentry.startSpan({ name: 'test_span_1' }, () => undefined); | ||
Sentry.startSpan({ name: 'test_span_2' }, () => undefined); |
38 changes: 38 additions & 0 deletions
38
...tegration-tests/suites/public-api/startSpan/parallel-root-spans-with-parentSpanId/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import { expect } from '@playwright/test'; | ||
|
||
import type { TransactionEvent } from '@sentry/types'; | ||
import { sentryTest } from '../../../../utils/fixtures'; | ||
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../utils/helpers'; | ||
|
||
sentryTest( | ||
'should send manually started parallel root spans in root context with parentSpanId', | ||
async ({ getLocalTestUrl, page }) => { | ||
if (shouldSkipTracingTest()) { | ||
sentryTest.skip(); | ||
} | ||
|
||
const url = await getLocalTestUrl({ testDir: __dirname }); | ||
|
||
const transaction1ReqPromise = waitForTransactionRequest(page, event => event.transaction === 'test_span_1'); | ||
const transaction2ReqPromise = waitForTransactionRequest(page, event => event.transaction === 'test_span_2'); | ||
|
||
await page.goto(url); | ||
|
||
const [transaction1Req, transaction2Req] = await Promise.all([transaction1ReqPromise, transaction2ReqPromise]); | ||
|
||
const transaction1 = envelopeRequestParser<TransactionEvent>(transaction1Req); | ||
const transaction2 = envelopeRequestParser<TransactionEvent>(transaction2Req); | ||
|
||
expect(transaction1).toBeDefined(); | ||
expect(transaction2).toBeDefined(); | ||
|
||
const trace1Id = transaction1.contexts?.trace?.trace_id; | ||
const trace2Id = transaction2.contexts?.trace?.trace_id; | ||
|
||
expect(trace1Id).toBe('12345678901234567890123456789012'); | ||
expect(trace2Id).toBe('12345678901234567890123456789012'); | ||
|
||
expect(transaction1.contexts?.trace?.parent_span_id).toBe('1234567890123456'); | ||
expect(transaction2.contexts?.trace?.parent_span_id).toBe('1234567890123456'); | ||
}, | ||
); |
2 changes: 2 additions & 0 deletions
2
...ages/browser-integration-tests/suites/public-api/startSpan/parallel-root-spans/subject.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Sentry.startSpan({ name: 'test_span_1' }, () => undefined); | ||
Sentry.startSpan({ name: 'test_span_2' }, () => undefined); |
38 changes: 38 additions & 0 deletions
38
...ackages/browser-integration-tests/suites/public-api/startSpan/parallel-root-spans/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import { expect } from '@playwright/test'; | ||
|
||
import type { TransactionEvent } from '@sentry/types'; | ||
import { sentryTest } from '../../../../utils/fixtures'; | ||
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../utils/helpers'; | ||
|
||
sentryTest('should send manually started parallel root spans in root context', async ({ getLocalTestUrl, page }) => { | ||
if (shouldSkipTracingTest()) { | ||
sentryTest.skip(); | ||
} | ||
|
||
const url = await getLocalTestUrl({ testDir: __dirname }); | ||
|
||
const transaction1ReqPromise = waitForTransactionRequest(page, event => event.transaction === 'test_span_1'); | ||
const transaction2ReqPromise = waitForTransactionRequest(page, event => event.transaction === 'test_span_2'); | ||
|
||
await page.goto(url); | ||
|
||
const [transaction1Req, transaction2Req] = await Promise.all([transaction1ReqPromise, transaction2ReqPromise]); | ||
|
||
const transaction1 = envelopeRequestParser<TransactionEvent>(transaction1Req); | ||
const transaction2 = envelopeRequestParser<TransactionEvent>(transaction2Req); | ||
|
||
expect(transaction1).toBeDefined(); | ||
expect(transaction2).toBeDefined(); | ||
|
||
const trace1Id = transaction1.contexts?.trace?.trace_id; | ||
const trace2Id = transaction2.contexts?.trace?.trace_id; | ||
|
||
expect(trace1Id).toBeDefined(); | ||
expect(trace2Id).toBeDefined(); | ||
|
||
// We use the same traceID from the root propagation context here | ||
expect(trace1Id).toBe(trace2Id); | ||
|
||
expect(transaction1.contexts?.trace?.parent_span_id).toBeUndefined(); | ||
expect(transaction2.contexts?.trace?.parent_span_id).toBeUndefined(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
dev-packages/e2e-tests/test-applications/nextjs-15/app/redirect/destination/page.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default function RedirectDestinationPage() { | ||
return ( | ||
<div> | ||
<h1>Redirect Destination</h1> | ||
</div> | ||
); | ||
} |
18 changes: 18 additions & 0 deletions
18
dev-packages/e2e-tests/test-applications/nextjs-15/app/redirect/origin/page.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { redirect } from 'next/navigation'; | ||
|
||
async function redirectAction() { | ||
'use server'; | ||
|
||
redirect('/redirect/destination'); | ||
} | ||
|
||
export default function RedirectOriginPage() { | ||
return ( | ||
<> | ||
{/* @ts-ignore */} | ||
<form action={redirectAction}> | ||
<button type="submit">Redirect me</button> | ||
</form> | ||
</> | ||
); | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minimum required versions are the following:
It's added at the bottom of the PR description: #14473