feat(core): Ensure normalizedRequest on sdkProcessingMetadata is merged
#14315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
mydea
changed the title
normalizedRequest on sdkProcessingMetadata is mergednormalizedRequest on sdkProcessingMetadata is merged
mydea
force-pushed
the
fn/normalizedRequestMerge
branch
from
e8533fa
to
cd85f65
Compare
mydea
force-pushed
the
fn/normalizedRequestMerge
branch
2 times, most recently
from
a56fc65
to
4705e11
Compare
mydea
commented
Nov 19, 2024
| @@ -95,6 +95,13 @@ describe('createSpanEnvelope', () => { | |||
| client = new TestClient(options); | |||
| setCurrentClient(client); | |||
| client.init(); | |||
|
|
|||
| // We want to avoid console errors in the tests | |||
| jest.spyOn(console, 'error').mockImplementation(() => {}); | |||
There was a problem hiding this comment.
Finally added this because it kept annoying me when running these tests locally to get this test log output all the time 😅
There was a problem hiding this comment.
Actually I'll move this out to #14358
lforst
approved these changes
Nov 19, 2024
mydea
force-pushed
the
fn/normalizedRequestMerge
branch
from
fc7c7b5
to
003f261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep
normalizedRequestwith data like headers, urls etc. on thesdkProcessingMetadataon the scope.While this generally works, there are some potential pitfalls/footguns there:
One, if you put some (e.g. partial)
normalizedRequeston the current scope, it will just overwrite the fullnormalizedRequestfrom the isolation scope, where generally we'll try to put the request data automatically (e.g. in the http instrumentation). Think this example:the resulting event inside of this
withScopecallback would only have the headers, but would miss e.g. url etc. data set.This PR changes this so that the
normalizedRequestis merged between the types of scopes, so only set fields on e.g. the current scope will overwrite the same fields on the isolation scope, instead of just overwriting the whole normalizedRequest that results.Note that bundle size for browser is sadly anyhow affected (no matter if we go with a/b/c), as the code to merge it between scopes is always shared :(