Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): Single implementation to fetch debug ids #14199

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Nov 6, 2024

In the process of fixing getsentry/sentry-electron#1011 I was looking for a way to get a Map<Filename, DebugId>. I found that there was already some code duplication for parsing and caching of debug ids from the polyfilled globals.

This PR moves the common code to @sentry/utils which will be useful for fixing the above.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.77 KB +0.05% +10 B 🔺
@sentry/browser - with treeshaking flags 21.53 KB -0.03% -6 B 🔽
@sentry/browser (incl. Tracing) 35.26 KB +0.03% +10 B 🔺
@sentry/browser (incl. Tracing, Replay) 71.98 KB +0.03% +18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.35 KB +0.01% +3 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.31 KB +0.03% +17 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.13 KB +0.02% +17 B 🔺
@sentry/browser (incl. Feedback) 39.92 KB +0.05% +17 B 🔺
@sentry/browser (incl. sendFeedback) 27.42 KB +0.04% +11 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.21 KB +0.05% +14 B 🔺
@sentry/react 25.52 KB +0.05% +13 B 🔺
@sentry/react (incl. Tracing) 38.22 KB +0.06% +22 B 🔺
@sentry/vue 26.91 KB +0.05% +13 B 🔺
@sentry/vue (incl. Tracing) 37.1 KB +0.06% +22 B 🔺
@sentry/svelte 22.9 KB +0.05% +10 B 🔺
CDN Bundle 24.12 KB +0.06% +13 B 🔺
CDN Bundle (incl. Tracing) 37.03 KB +0.07% +23 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.69 KB +0.02% +13 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.04 KB +0.03% +19 B 🔺
CDN Bundle - uncompressed 70.68 KB +0.04% +22 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 109.86 KB +0.02% +22 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.38 KB +0.01% +22 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.6 KB +0.01% +22 B 🔺
@sentry/nextjs (client) 38.33 KB +0.05% +19 B 🔺
@sentry/sveltekit (client) 35.84 KB +0.03% +11 B 🔺
@sentry/node 131.54 KB +0.02% +20 B 🔺
@sentry/node - without tracing 95.67 KB +0.03% +29 B 🔺
@sentry/aws-serverless 105.93 KB +0.03% +23 B 🔺

View base workflow run

@timfish timfish marked this pull request as ready for review November 6, 2024 22:27
@AbhiPrasad AbhiPrasad merged commit b2605be into develop Nov 7, 2024
185 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/debug-ids-cache branch November 7, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants