debug(replay): Remove noisy log that is causing event buffer overflow as well #14069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s well Removes a log statement that is output when buffer is already full (which will keep overflowing the buffer). Also noticed a log statement in `stop()` that would trigger when we stop due to event buffer being full, which would compoound the issue. This last fix should be pulled into the SDK.
billyvg
changed the title
size-limit report 📦
|
c298lee
approved these changes
Oct 23, 2024
billyvg
deleted the
debug-replay-remove-noisy-log-do-not-log-when-event-size-exceeded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a log statement that is output when buffer is already full (which will keep overflowing the buffer). Also noticed a log statement in
stop()that would trigger when we stop due to event buffer being full, which would compoound the issue. This last fix should be pulled into the SDK.