Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Fix onError callback #14002

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 16, 2024

This fixes the onError callback added in #13721 -- the option itself was not being propagated to the replay options.

This fixes the `onError` callback added in #13721 -- the option itself was not being propagated to the replay options.
Copy link

codecov bot commented Oct 16, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
634 1 633 31
View the top 1 failed tests by shortest run time
replay/dsc/test.ts should add replay_id to dsc of transactions when in session mode
Stack Traces | 1.15s run time
test.ts:19:11 should add replay_id to dsc of transactions when in session mode

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant