Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure type for init is correct in meta frameworks #13938

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 10, 2024

Fixes #13932

We have defined the type for the shared client/server types in meta-frameworks incorrectly, init now returns Client | undefined and not void anymore.

@mydea mydea self-assigned this Oct 10, 2024
@mydea mydea merged commit 1d87cec into develop Oct 11, 2024
128 checks passed
@mydea mydea deleted the fn/remix-init-type branch October 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@sentry/remix] init method is typed to return void, but actually returns the client
3 participants