-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudflare): Add withSentry
method
#13025
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,82 @@ | |
**Note: This SDK is unreleased. Please follow the | ||
[tracking GH issue](https://github.com/getsentry/sentry-javascript/issues/12620) for updates.** | ||
|
||
## Usage | ||
Below details the setup for the Cloudflare Workers. Cloudflare Pages support is in active development. | ||
|
||
TODO: Add usage instructions here. | ||
## Setup (Cloudflare Workers) | ||
|
||
To get started, first install the `@sentry/cloudflare` package: | ||
|
||
```bash | ||
npm install @sentry/cloudflare | ||
``` | ||
|
||
Then set either the `nodejs_compat` or `nodejs_als` compatibility flags in your `wrangler.toml`. This is because the SDK | ||
needs access to the `AsyncLocalStorage` API to work correctly. | ||
|
||
```toml | ||
compatibility_flags = ["nodejs_compat"] | ||
# compatibility_flags = ["nodejs_als"] | ||
``` | ||
|
||
To use this SDK, wrap your handler with the `withSentry` function. This will initialize the SDK and hook into the | ||
environment. Note that you can turn off almost all side effects using the respective options. | ||
|
||
Currently only ESM handlers are supported. | ||
|
||
```javascript | ||
import * as Sentry from '@sentry/cloudflare'; | ||
|
||
export default withSentry( | ||
(env) => ({ | ||
dsn: env.SENTRY_DSN, | ||
// Set tracesSampleRate to 1.0 to capture 100% of spans for tracing. | ||
tracesSampleRate: 1.0, | ||
}), | ||
{ | ||
async fetch(request, env, ctx) { | ||
return new Response('Hello World!'); | ||
}, | ||
} satisfies ExportedHandler<Env> | ||
); | ||
``` | ||
|
||
### Sourcemaps (Cloudflare Workers) | ||
|
||
Configure uploading sourcemaps via the Sentry Wizard: | ||
|
||
```bash | ||
npx @sentry/wizard@latest -i sourcemaps | ||
``` | ||
|
||
See more details in our [docs](https://docs.sentry.io/platforms/javascript/sourcemaps/). | ||
|
||
## Usage (Cloudflare Workers) | ||
|
||
To set context information or send manual events, use the exported functions of `@sentry/cloudflare`. Note that these | ||
functions will require your exported handler to be wrapped in `withSentry`. | ||
|
||
```javascript | ||
import * as Sentry from '@sentry/cloudflare'; | ||
|
||
// Set user information, as well as tags and further extras | ||
Sentry.setExtra('battery', 0.7); | ||
Sentry.setTag('user_mode', 'admin'); | ||
Sentry.setUser({ id: '4711' }); | ||
|
||
// Add a breadcrumb for future events | ||
Sentry.addBreadcrumb({ | ||
message: 'My Breadcrumb', | ||
// ... | ||
}); | ||
|
||
// Capture exceptions, messages or manual events | ||
Sentry.captureMessage('Hello, world!'); | ||
Sentry.captureException(new Error('Good bye')); | ||
Sentry.captureEvent({ | ||
message: 'Manual', | ||
stacktrace: [ | ||
// ... | ||
], | ||
}); | ||
Comment on lines
+79
to
+98
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. q: From your issue:
Wouldn't these suffer from the same issue of going stale? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope, because under the hood they call |
||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
import type { | ||
ExportedHandler, | ||
ExportedHandlerFetchHandler, | ||
IncomingRequestCfProperties, | ||
} from '@cloudflare/workers-types'; | ||
import { | ||
SEMANTIC_ATTRIBUTE_SENTRY_OP, | ||
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, | ||
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, | ||
captureException, | ||
continueTrace, | ||
flush, | ||
setHttpStatus, | ||
startSpan, | ||
withIsolationScope, | ||
} from '@sentry/core'; | ||
import type { Options, Scope, SpanAttributes } from '@sentry/types'; | ||
import { stripUrlQueryAndFragment, winterCGRequestToRequestData } from '@sentry/utils'; | ||
import { setAsyncLocalStorageAsyncContextStrategy } from './async'; | ||
import { init } from './sdk'; | ||
|
||
/** | ||
* Extract environment generic from exported handler. | ||
*/ | ||
type ExtractEnv<P> = P extends ExportedHandler<infer Env> ? Env : never; | ||
|
||
/** | ||
* Wrapper for Cloudflare handlers. | ||
* | ||
* Initializes the SDK and wraps the handler with Sentry instrumentation. | ||
* | ||
* Automatically instruments the `fetch` method of the handler. | ||
* | ||
* @param optionsCallback Function that returns the options for the SDK initialization. | ||
* @param handler {ExportedHandler} The handler to wrap. | ||
* @returns The wrapped handler. | ||
*/ | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
export function withSentry<E extends ExportedHandler<any>>( | ||
optionsCallback: (env: ExtractEnv<E>) => Options, | ||
handler: E, | ||
): E { | ||
setAsyncLocalStorageAsyncContextStrategy(); | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any | ||
if ('fetch' in handler && typeof handler.fetch === 'function' && !(handler.fetch as any).__SENTRY_INSTRUMENTED__) { | ||
handler.fetch = new Proxy(handler.fetch, { | ||
apply(target, thisArg, args: Parameters<ExportedHandlerFetchHandler<ExtractEnv<E>>>) { | ||
const [request, env, context] = args; | ||
return withIsolationScope(isolationScope => { | ||
const options = optionsCallback(env); | ||
const client = init(options); | ||
isolationScope.setClient(client); | ||
|
||
const attributes: SpanAttributes = { | ||
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.cloudflare-worker', | ||
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url', | ||
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.server', | ||
['http.request.method']: request.method, | ||
['url.full']: request.url, | ||
}; | ||
|
||
const contentLength = request.headers.get('content-length'); | ||
if (contentLength) { | ||
attributes['http.request.body.size'] = parseInt(contentLength, 10); | ||
} | ||
|
||
let pathname = ''; | ||
try { | ||
const url = new URL(request.url); | ||
pathname = url.pathname; | ||
attributes['server.address'] = url.hostname; | ||
attributes['url.scheme'] = url.protocol.replace(':', ''); | ||
} catch { | ||
// skip | ||
} | ||
|
||
addRequest(isolationScope, request); | ||
addCloudResourceContext(isolationScope); | ||
if (request.cf) { | ||
addCultureContext(isolationScope, request.cf); | ||
attributes['network.protocol.name'] = request.cf.httpProtocol; | ||
} | ||
|
||
const routeName = `${request.method} ${pathname ? stripUrlQueryAndFragment(pathname) : '/'}`; | ||
|
||
return continueTrace( | ||
{ sentryTrace: request.headers.get('sentry-trace') || '', baggage: request.headers.get('baggage') }, | ||
() => { | ||
// Note: This span will not have a duration unless I/O happens in the handler. This is | ||
// because of how the cloudflare workers runtime works. | ||
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/ | ||
return startSpan( | ||
{ | ||
name: routeName, | ||
attributes, | ||
}, | ||
async span => { | ||
try { | ||
const res = await (target.apply(thisArg, args) as ReturnType<typeof target>); | ||
setHttpStatus(span, res.status); | ||
return res; | ||
} catch (e) { | ||
captureException(e, { mechanism: { handled: false, type: 'cloudflare' } }); | ||
throw e; | ||
} finally { | ||
context.waitUntil(flush(2000)); | ||
} | ||
}, | ||
); | ||
}, | ||
); | ||
}); | ||
}, | ||
}); | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any | ||
(handler.fetch as any).__SENTRY_INSTRUMENTED__ = true; | ||
} | ||
|
||
return handler; | ||
} | ||
|
||
function addCloudResourceContext(isolationScope: Scope): void { | ||
isolationScope.setContext('cloud_resource', { | ||
'cloud.provider': 'cloudflare', | ||
}); | ||
} | ||
|
||
function addCultureContext(isolationScope: Scope, cf: IncomingRequestCfProperties): void { | ||
isolationScope.setContext('culture', { | ||
timezone: cf.timezone, | ||
}); | ||
} | ||
|
||
function addRequest(isolationScope: Scope, request: Request): void { | ||
isolationScope.setSDKProcessingMetadata({ request: winterCGRequestToRequestData(request) }); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,47 @@ | ||
import { | ||
dedupeIntegration, | ||
functionToStringIntegration, | ||
getIntegrationsToSetup, | ||
inboundFiltersIntegration, | ||
initAndBind, | ||
linkedErrorsIntegration, | ||
requestDataIntegration, | ||
} from '@sentry/core'; | ||
import type { Integration, Options } from '@sentry/types'; | ||
import { stackParserFromStackParserOptions } from '@sentry/utils'; | ||
import type { CloudflareClientOptions } from './client'; | ||
import { CloudflareClient } from './client'; | ||
|
||
import { fetchIntegration } from './integrations/fetch'; | ||
import { makeCloudflareTransport } from './transport'; | ||
import { defaultStackParser } from './vendor/stacktrace'; | ||
|
||
/** Get the default integrations for the Cloudflare SDK. */ | ||
export function getDefaultIntegrations(options: Options): Integration[] { | ||
const integrations = [ | ||
export function getDefaultIntegrations(_options: Options): Integration[] { | ||
return [ | ||
dedupeIntegration(), | ||
inboundFiltersIntegration(), | ||
functionToStringIntegration(), | ||
linkedErrorsIntegration(), | ||
fetchIntegration(), | ||
requestDataIntegration(), | ||
]; | ||
} | ||
|
||
if (options.sendDefaultPii) { | ||
integrations.push(requestDataIntegration()); | ||
/** | ||
* Initializes the cloudflare SDK. | ||
*/ | ||
export function init(options: Options): CloudflareClient | undefined { | ||
if (options.defaultIntegrations === undefined) { | ||
options.defaultIntegrations = getDefaultIntegrations(options); | ||
} | ||
|
||
return integrations; | ||
const clientOptions: CloudflareClientOptions = { | ||
...options, | ||
stackParser: stackParserFromStackParserOptions(options.stackParser || defaultStackParser), | ||
integrations: getIntegrationsToSetup(options), | ||
transport: options.transport || makeCloudflareTransport, | ||
}; | ||
|
||
return initAndBind(CloudflareClient, clientOptions) as CloudflareClient; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment explaining this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 5671b7b