-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): Add server error hook #12796
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dcadf22
feat(nuxt): Add server error hook
s1gr1d 85359f8
add hint data
s1gr1d d77c2e5
Update packages/nuxt/src/runtime/plugins/sentry.server.ts
s1gr1d a374ce5
Merge branch 'develop' into sig/nuxt-server
s1gr1d 795d1ea
extract structured context
s1gr1d cea2347
Merge branch 'develop' into sig/nuxt-server
s1gr1d 9a6f43c
fix test
s1gr1d 1af2673
review changes
s1gr1d 165cf5e
Merge branch 'develop' into sig/nuxt-server
s1gr1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { captureException } from '@sentry/node'; | ||
import { H3Error } from 'h3'; | ||
import { defineNitroPlugin } from 'nitropack/runtime'; | ||
|
||
export default defineNitroPlugin(nitroApp => { | ||
nitroApp.hooks.hook('error', (error, context) => { | ||
// Do not handle 404 and 422 | ||
if (error instanceof H3Error) { | ||
if (error.statusCode === 404 || error.statusCode === 422) { | ||
return; | ||
} | ||
} | ||
|
||
if (context) { | ||
captureException(error, { | ||
captureContext: { extra: { nuxt: context } }, | ||
s1gr1d marked this conversation as resolved.
Show resolved
Hide resolved
|
||
mechanism: { handled: false }, | ||
}); | ||
} else { | ||
captureException(error, { mechanism: { handled: false } }); | ||
} | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l/m: We could arguably skip all 4xxs (also 3xxs if that can ever happen).