Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove es-check from deps #12686

Merged
merged 1 commit into from
Jun 28, 2024
Merged

chore: Remove es-check from deps #12686

merged 1 commit into from
Jun 28, 2024

Conversation

AbhiPrasad
Copy link
Member

ref: #12644

We don't use es-check anymore, we can remove it. It was previously used to validate our es5 builds, but we don't target that anymore.

Extracted from the previous PR because 1 big change was breaking CI and I couldn't figure out the root cause.

This is no longer being used by any deps in Sentry.
@AbhiPrasad AbhiPrasad requested a review from a team June 27, 2024 20:30
@AbhiPrasad AbhiPrasad self-assigned this Jun 27, 2024
@AbhiPrasad AbhiPrasad requested review from lforst and andreiborza and removed request for a team June 27, 2024 20:30
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) June 27, 2024 20:30
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.22 KB (0%)
@sentry/browser (incl. Tracing) 33.38 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing, Replay) 69.16 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.49 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.22 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.82 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.68 KB (+0.09% 🔺)
@sentry/browser (incl. metrics) 26.5 KB (0%)
@sentry/browser (incl. Feedback) 38.86 KB (0%)
@sentry/browser (incl. sendFeedback) 26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.45 KB (0%)
@sentry/react 24.97 KB (0%)
@sentry/react (incl. Tracing) 36.43 KB (+0.18% 🔺)
@sentry/vue 26.33 KB (0%)
@sentry/vue (incl. Tracing) 35.24 KB (+0.2% 🔺)
@sentry/svelte 22.36 KB (0%)
CDN Bundle 23.42 KB (0%)
CDN Bundle (incl. Tracing) 35.12 KB (+0.21% 🔺)
CDN Bundle (incl. Tracing, Replay) 69.25 KB (+0.11% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.45 KB (+0.1% 🔺)
CDN Bundle - uncompressed 68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.82 KB (+0.16% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.29 KB (+0.08% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227 KB (+0.08% 🔺)
@sentry/nextjs (client) 36.3 KB (+0.19% 🔺)
@sentry/sveltekit (client) 34.02 KB (+0.2% 🔺)
@sentry/node 130.61 KB (0%)
@sentry/node - without tracing 91.63 KB (0%)
@sentry/aws-serverless 116.8 KB (0%)

@AbhiPrasad AbhiPrasad merged commit c7b8503 into develop Jun 28, 2024
113 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-es-check branch June 28, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants