-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(browser): Use Proxy
for XHR instrumentation
#12212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please add a test!
size-limit report 📦
|
this fixes half of the issue in that it provides proper names for the xhr prototype functions. however, this is still a culprit:
this implementation per se is fine, unfortunately it conflicts with
|
Proxy
for XHR instrumentation
@DerGernTod makes sense. In your original issue, you're describing a symptom rather than the thing you would like to achieve. I changed the implementation to be based on proxies. I think that should resolve most if not all of your problems. Can you confirm that? |
i tried your changes with our tests and looks like it works fine. nice, thanks! |
Fixes #12208
The implementation with proxy should be "more" transparent with regards to things like
XMLHttpRequest.prototype.open.toString()
for example.Note: Proxies have less support than the previous implementation but it is still within our policy