Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverless): Check if cloud event callback is a function (#9044) #11701

Merged

Conversation

tcoyze
Copy link
Contributor

@tcoyze tcoyze commented Apr 19, 2024

Closes #9044

Adds relevant tests for testing handlers that return promises.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch from 6e4e95d to f2d903b Compare April 19, 2024 18:38
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch from f2d903b to b176eb6 Compare April 22, 2024 15:22
@tcoyze
Copy link
Contributor Author

tcoyze commented Apr 22, 2024

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution!

@AbhiPrasad
Copy link
Member

ah seems like theres some formatting issues. https://github.com/getsentry/sentry-javascript/actions/runs/8787015686/job/24111825459?pr=11701

Running yarn fix in the package root should handle that!

@tcoyze
Copy link
Contributor Author

tcoyze commented Apr 22, 2024

FWIW I have been having build issues, apologies for the failed checks. Resolving those now!

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch 2 times, most recently from e18db31 to 9728041 Compare April 22, 2024 16:33
@tcoyze
Copy link
Contributor Author

tcoyze commented Apr 22, 2024

@AbhiPrasad Thanks! Fixed that, and rebased 😄

@tcoyze tcoyze force-pushed the fix/gcpfunction-cloud-events-callback branch from 9728041 to f3d3c16 Compare April 22, 2024 16:36
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 22, 2024
@AbhiPrasad AbhiPrasad merged commit 6a8a410 into getsentry:develop Apr 22, 2024
35 checks passed
@AbhiPrasad
Copy link
Member

develop reflects our current work on 8.0.0, the next major version. I'll take care of backporting this change to the 7.0.0 set of SDKs - #11729

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: callback is not a function thrown by Sentry.GCPFunction.wrapCloudEventFunction
2 participants