-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(serverless): Check if cloud event callback is a function (#9044) #11701
fix(serverless): Check if cloud event callback is a function (#9044) #11701
Conversation
6e4e95d
to
f2d903b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a PR! Could you add a test to https://github.com/getsentry/sentry-javascript/blob/f2d903b1e034bd2c388fb0d8d63ce7fce8ef9ef9/packages/google-cloud-serverless/test/gcpfunction/cloud_event.test.ts about this?
f2d903b
to
b176eb6
Compare
@AbhiPrasad Tests added! Thanks for the review 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for you contribution!
ah seems like theres some formatting issues. https://github.com/getsentry/sentry-javascript/actions/runs/8787015686/job/24111825459?pr=11701 Running |
FWIW I have been having build issues, apologies for the failed checks. Resolving those now! |
e18db31
to
9728041
Compare
@AbhiPrasad Thanks! Fixed that, and rebased 😄 |
9728041
to
f3d3c16
Compare
Thanks! |
Closes #9044
Adds relevant tests for testing handlers that return promises.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).