feat(core): Add default behaviour for rewriteFramesIntegration in browser
#11535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
commented
Apr 11, 2024
| const root = options.root; | ||
| const prefix = options.prefix || 'app:///'; | ||
|
|
||
| const iteratee: StackFrameIteratee = |
There was a problem hiding this comment.
I re-shuffled the code a bit so we can test it more easily
s1gr1d
approved these changes
Apr 11, 2024
mydea
reviewed
Apr 11, 2024
| } | ||
| return frame; | ||
| }); | ||
| const isBrowser = 'window' in GLOBAL_OBJ && GLOBAL_OBJ.window !== undefined; |
There was a problem hiding this comment.
l: Can we just compress this to !!GLOBAL_OBJ.window? I think that should be safe enough..?
There was a problem hiding this comment.
typescript sadness but yeah
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6423
Adds functionality on the browser for the
rootoption.