fix(nextjs): Remove webpack:// prefix more broadly from source map sources field
#10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Swatinem
reviewed
Feb 13, 2024
| @@ -764,7 +764,7 @@ export function getWebpackPluginOptions( | |||
| project: process.env.SENTRY_PROJECT, | |||
| authToken: process.env.SENTRY_AUTH_TOKEN, | |||
| configFile: hasSentryProperties ? 'sentry.properties' : undefined, | |||
| stripPrefix: ['webpack://_N_E/'], | |||
| stripPrefix: ['webpack://_N_E/', 'webpack://'], | |||
There was a problem hiding this comment.
Does this really help?
Because in our example, this would just turn webpack://sentry-docs/app/changelog/%5Fadmin/page.tsx into sentry-docs/app/changelog/%5Fadmin/page.tsx
not quite sure if thats better?
There was a problem hiding this comment.
I would argue it is better 1) because symbolicator is marking in-app frames as non-in-app because of this prefix 2) it is more aesthetic and less confusing (?).
AbhiPrasad
approved these changes
Feb 13, 2024
This was referenced Feb 14, 2024
This was referenced Mar 12, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like newer versions of Next.js do not use the
_N_Enamespace anymore but leave it up to the user. We need to adjust our config for that.We should in the near future add E2E tests that check for source mapping in Next.js.